[AIRFLOW-4819] Fix singleton-comparision errors in pylint#5440
Merged
potiuk merged 1 commit intoapache:masterfrom Jun 20, 2019
Merged
[AIRFLOW-4819] Fix singleton-comparision errors in pylint#5440potiuk merged 1 commit intoapache:masterfrom
potiuk merged 1 commit intoapache:masterfrom
Conversation
fbb7c7b to
3e165b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #5440 +/- ##
=======================================
Coverage 79.11% 79.11%
=======================================
Files 488 488
Lines 30582 30582
=======================================
Hits 24194 24194
Misses 6388 6388
Continue to review full report at Codecov.
|
potiuk
approved these changes
Jun 20, 2019
Contributor
|
@mik-laj FYI SQLAlchemy has some linter-friendly functions to avoid e.g. query.filter(User.name == None)
# linter friendly equivalent:
query.filter(User.name.is_(None))More here: https://docs.sqlalchemy.org/en/13/orm/tutorial.html#common-filter-operators |
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8