Skip to content

[AIRFLOW-4819] Fix singleton-comparision errors in pylint#5440

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pylint-singleton
Jun 20, 2019
Merged

[AIRFLOW-4819] Fix singleton-comparision errors in pylint#5440
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pylint-singleton

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 20, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-4819] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4819
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj force-pushed the pylint-singleton branch from fbb7c7b to 3e165b6 Compare June 20, 2019 01:32
@codecov-io
Copy link

Codecov Report

Merging #5440 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5440   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files         488      488           
  Lines       30582    30582           
=======================================
  Hits        24194    24194           
  Misses       6388     6388
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 70.32% <ø> (ø) ⬆️
airflow/www/security.py 92.3% <ø> (ø) ⬆️
airflow/models/dagrun.py 96.48% <ø> (ø) ⬆️
airflow/models/dag.py 91.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ebc7d...3e165b6. Read the comment docs.

@mik-laj mik-laj requested review from BasPH and potiuk June 20, 2019 02:08
@potiuk potiuk merged commit c001c80 into apache:master Jun 20, 2019
@BasPH
Copy link
Contributor

BasPH commented Jun 22, 2019

@mik-laj FYI SQLAlchemy has some linter-friendly functions to avoid e.g. == None and make linters happy:

query.filter(User.name == None)

# linter friendly equivalent:
query.filter(User.name.is_(None))

More here: https://docs.sqlalchemy.org/en/13/orm/tutorial.html#common-filter-operators

andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants