Skip to content

[AIRFLOW-4827] Remove compatible test for python 2#5448

Merged
XD-DENG merged 1 commit intoapache:masterfrom
zhongjiajie:test_remove_compatible_python2
Jun 21, 2019
Merged

[AIRFLOW-4827] Remove compatible test for python 2#5448
XD-DENG merged 1 commit intoapache:masterfrom
zhongjiajie:test_remove_compatible_python2

Conversation

@zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Jun 20, 2019

Make sure you have checked all steps below.

Jira

Code Quality

  • Passes flake8

@OmerJog
Copy link
Contributor

OmerJog commented Jun 20, 2019

Shouldnt you target https://issues.apache.org/jira/browse/AIRFLOW-4827 ?

@zhongjiajie zhongjiajie changed the title [AIRFLOW-4196] Remove compatible test for python 2 [AIRFLOW-4827] Remove compatible test for python 2 Jun 20, 2019
@zhongjiajie
Copy link
Member Author

😭 What the matter today. Two PR connect to wrong Jira tickets
Thanks for you remind @OmerJog

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #5448 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5448     +/-   ##
=========================================
+ Coverage   79.01%   79.11%   +0.1%     
=========================================
  Files         488      488             
  Lines       30564    30564             
=========================================
+ Hits        24151    24182     +31     
+ Misses       6413     6382     -31
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 60.27% <0%> (+1.02%) ⬆️
airflow/jobs/scheduler_job.py 70.18% <0%> (+1.24%) ⬆️
airflow/executors/__init__.py 66.66% <0%> (+4.16%) ⬆️
airflow/utils/sqlalchemy.py 80.95% <0%> (+4.76%) ⬆️
airflow/executors/sequential_executor.py 100% <0%> (+52.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a89175...488c848. Read the comment docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you have removed wrong test case?
The test case you removed will be skipped if Py version < 3.4, i.e., this test case is the one for Py 3.4+ which should be kept.
(I haven't looked into the test case details. Justing checking the @unittest.skipIf conditions)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right, a wrong remove

@zhongjiajie zhongjiajie force-pushed the test_remove_compatible_python2 branch from ec05b9e to 488c848 Compare June 21, 2019 02:05
@zhongjiajie
Copy link
Member Author

CI green, PTAL @XD-DENG thanks.

@XD-DENG XD-DENG merged commit e6d1f99 into apache:master Jun 21, 2019
@XD-DENG
Copy link
Member

XD-DENG commented Jun 21, 2019

Thanks @zhongjiajie

@zhongjiajie
Copy link
Member Author

Thanks @XD-DENG

@zhongjiajie zhongjiajie deleted the test_remove_compatible_python2 branch June 21, 2019 06:44
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants