Skip to content

[AIRFLOW-4828] Remove parameter python_version#5449

Closed
zhongjiajie wants to merge 2 commits intoapache:masterfrom
zhongjiajie:operator_python_rm_version
Closed

[AIRFLOW-4828] Remove parameter python_version#5449
zhongjiajie wants to merge 2 commits intoapache:masterfrom
zhongjiajie:operator_python_rm_version

Conversation

@zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Jun 20, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Part of AIP-3 Drop support for Python 2

Code Quality

  • Passes flake8

@OmerJog
Copy link
Contributor

OmerJog commented Jun 20, 2019

Shouldnt you target https://issues.apache.org/jira/browse/AIRFLOW-4828 ?

@zhongjiajie
Copy link
Member Author

@OmerJog Oh, my bad. Thanks for you help

@zhongjiajie zhongjiajie changed the title [AIRFLOW-4196] Remove parameter python_version [AIRFLOW-4828] Remove parameter python_version Jun 20, 2019
@kurtqq
Copy link
Contributor

kurtqq commented Jun 20, 2019

I don't think we should remove python_version parameter.
If I run Airflow on Python 3.5 and want to run a task with Python 3.7 I need the python_version parameter.
Moreover in the future Python 4 will be released. Airflow will likely support both for a while....

I think the python_version needs to stay it's not unique to Python 2.7

I also think that if someone wants to run something with Python 2.7 with the PythonVirtualenvOperator he is more than welcome. There is no need to prevent the user from doing so. Airflow can just remove the test for this so if something is not working it's the user problem.

@XD-DENG
Copy link
Member

XD-DENG commented Jun 21, 2019

Agree with @kurtqq .

  • To my understanding, [AIP-3 drop support Python 2] is to drop Py2 support to Airflow itself only.
  • Minor version ("x" in "3.x") matters.

@zhongjiajie
Copy link
Member Author

Will close it, thanks for the clarification @kurtqq @XD-DENG

@XD-DENG
Copy link
Member

XD-DENG commented Jun 21, 2019

Thanks @zhongjiajie

@zhongjiajie zhongjiajie deleted the operator_python_rm_version branch June 21, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants