Disable start_from_trigger altogether for now#54646
Conversation
f290086 to
2ce1736
Compare
|
What do we have to do to re-enable it for 3.1 timeframe? |
2ce1736 to
d98bb86
Compare
|
We need to figure out how to render the task template without spawning a worker (or at least be able to spawn a process that’s significantly more lightweight than a task worker) to make this worthwhile. Otherwise I feel we should just remove this feature altogether since it would not provide any benefits. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 91e1029 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Not going to backport per suggestion from @vatsrahul1001. This issue is not repro-able in 3.0.x. |
I have a PR open for that, it's a pity this has been closed as my PR is ready to be merged. |
Close #54627. See in-code comments for details.