Skip to content

[AIRFLOW-4844] Added optional is_paused_upon_creation argument for da…#5482

Closed
Sinsin1367 wants to merge 1 commit intoapache:v1-10-stablefrom
Sinsin1367:v1-10-stable
Closed

[AIRFLOW-4844] Added optional is_paused_upon_creation argument for da…#5482
Sinsin1367 wants to merge 1 commit intoapache:v1-10-stablefrom
Sinsin1367:v1-10-stable

Conversation

@Sinsin1367
Copy link
Copy Markdown
Contributor

…gs to configure initial pause status upon creation.

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR:
  1. Adding the feature to configure each dag object with the initial state of is_paused flag
  2. The corresponding changes for python2 branch will be submitted once this review is finalized.

Tests

  • My PR adds the following unit tests:
  1. Adding unit test to test existing dags in database not being affected with the flag.
  2. Adding unit test to test new dags following the flag passed. (there are already unit tests testing backward compatibility of the the code change.)

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

…gs to configure initial pause status upon creation.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 26, 2019

Codecov Report

Merging #5482 into v1-10-stable will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           v1-10-stable    #5482      +/-   ##
================================================
- Coverage          79.5%   79.49%   -0.01%     
================================================
  Files               250      250              
  Lines             18264    18267       +3     
================================================
+ Hits              14520    14522       +2     
- Misses             3744     3745       +1
Impacted Files Coverage Δ
airflow/models/dag.py 93.72% <100%> (+0.02%) ⬆️
airflow/models/taskinstance.py 92.97% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e803d1...c281195. Read the comment docs.

@ashb
Copy link
Copy Markdown
Member

ashb commented Jun 26, 2019

Thanks, but don't worry about back-porting. We (the committers) will do that as we prefer to record the commit it is cherry-picked from. I'll deal with getting this in to the release.

@ashb ashb closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants