[AIRFLOW-4895] Import Iterable from collections.abc to fix DeprecationWarning in Python 3.7#5533
Merged
ashb merged 1 commit intoapache:masterfrom Jul 4, 2019
Merged
Conversation
…nWarning in Python 3.7
ashb
reviewed
Jul 4, 2019
| # Fix Python > 3.7 deprecation | ||
| from collections.abc import Iterable | ||
| except ImportError: | ||
| # Preserve Python < 3.3 compatibility |
Member
There was a problem hiding this comment.
The mimimum Python version we support is now 3.5 so I don't think we need this. (unless we also want to backport this to 1.10.x, where we still support py2.7)
Contributor
Author
There was a problem hiding this comment.
Thanks, it's also present in 1.10.x branch. The fix was based on https://issues.apache.org/jira/browse/AIRFLOW-3009 where similar problem was fixed in master and also seemed to be backported to 1.10.3.
Codecov Report
@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
- Coverage 79.07% 79.07% -0.01%
==========================================
Files 489 489
Lines 30744 30747 +3
==========================================
+ Hits 24312 24313 +1
- Misses 6432 6434 +2
Continue to review full report at Codecov.
|
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
…nWarning in airflow.utils (apache#5533)
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…nWarning in airflow.utils (apache#5533)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Description
Import Iterable from collections.abc to fix DeprecationWarning in Python 3.7. Use collections to ensure compatibility for Python 3.3 and below.
Tests
This fixes a DeprecationWarning and doesn't make code change
Commits
Code Quality
flake8