Skip to content

Don't import/load executor if it's not necessary#55742

Merged
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:onikolas/skip_exec_load_skip_serve_logs
Sep 17, 2025
Merged

Don't import/load executor if it's not necessary#55742
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:onikolas/skip_exec_load_skip_serve_logs

Conversation

@o-nikolas
Copy link
Contributor

If we are skipping log serving there is no need to import/load the executor to check if it supports log serving.

Discovered this small optimization when working on a related bit of code.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

If we are skipping log serving there is no need to import/load the
executor to check if it supports log serving.
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense.

@vincbeck vincbeck merged commit 7fee3e9 into apache:main Sep 17, 2025
61 checks passed
@vincbeck vincbeck deleted the onikolas/skip_exec_load_skip_serve_logs branch September 17, 2025 14:01
@kaxil kaxil added this to the Airflow 3.1.0 milestone Sep 18, 2025
kaxil pushed a commit that referenced this pull request Sep 18, 2025
If we are skipping log serving there is no need to import/load the
executor to check if it supports log serving.

(cherry picked from commit 7fee3e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants