Skip to content

[AIRFLOW-XXX] move ES logging params to correct deprecation section in configurations#5603

Merged
ashb merged 1 commit intoapache:v1-10-stablefrom
andriisoldatenko:hotfix-deprication-es-logging-config-vars
Jul 18, 2019
Merged

[AIRFLOW-XXX] move ES logging params to correct deprecation section in configurations#5603
ashb merged 1 commit intoapache:v1-10-stablefrom
andriisoldatenko:hotfix-deprication-es-logging-config-vars

Conversation

@andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Jul 17, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • This PR fix this commit
    move ES logging params to correct deprecation section in configurations

Tests

  • [x ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [x ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Documentation

  • [x ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • [ x] Passes flake8

@andriisoldatenko andriisoldatenko force-pushed the hotfix-deprication-es-logging-config-vars branch from 0140e67 to 57fe7a6 Compare July 17, 2019 21:33
@andriisoldatenko
Copy link
Contributor Author

@ash pls review.

@andriisoldatenko andriisoldatenko changed the title move ES logging params to correct deprecation section in configurations [AIRFLOW-XXX] move ES logging params to correct deprecation section in configurations Jul 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #5603 into v1-10-stable will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           v1-10-stable    #5603      +/-   ##
================================================
+ Coverage         79.29%   79.31%   +0.02%     
================================================
  Files               250      250              
  Lines             18326    18326              
================================================
+ Hits              14532    14536       +4     
+ Misses             3794     3790       -4
Impacted Files Coverage Δ
airflow/configuration.py 89.47% <ø> (ø) ⬆️
airflow/models/taskinstance.py 93.18% <0%> (+0.16%) ⬆️
airflow/utils/dag_processing.py 59.15% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd437d6...57fe7a6. Read the comment docs.

@ashb ashb merged commit ef88bfb into apache:v1-10-stable Jul 18, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants