Skip to content

[AIRFLOW-5007] Remove override of python version to 3.6 in tests#5628

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-accidental-python-version-override
Jul 21, 2019
Merged

[AIRFLOW-5007] Remove override of python version to 3.6 in tests#5628
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-accidental-python-version-override

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 21, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Python version should be forced to 3.6 only in static checks but it was accidentally forced to 3.6 in running the tests as well. It should be fixed quickly

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    All tests.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested a review from mik-laj July 21, 2019 16:00
@potiuk potiuk merged commit 7b56198 into apache:master Jul 21, 2019
potiuk added a commit that referenced this pull request Jul 21, 2019
potiuk added a commit that referenced this pull request Jul 22, 2019
potiuk added a commit to potiuk/airflow that referenced this pull request Jul 23, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Jul 23, 2019
serkef pushed a commit to serkef/airflow that referenced this pull request Jul 24, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants