Skip to content

[AIRFLOW-5063] Fix performance when switching between master/v1-10#5677

Merged
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:fix_performance_switching_v1-10
Jul 29, 2019
Merged

[AIRFLOW-5063] Fix performance when switching between master/v1-10#5677
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:fix_performance_switching_v1-10

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Jul 29, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested review from ashb and mik-laj July 29, 2019 06:18
Comment thread scripts/ci/in_container/_in_container_utils.sh
@potiuk potiuk merged commit 7e498b4 into apache:master Jul 29, 2019
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
@ashb
Copy link
Copy Markdown
Member

ashb commented Jul 31, 2019

This commit has changed the behaviour of mypy airflow/some/file.py -- it's ignoring the settings we have in setup.cfg because mypy.ini now exists and is empty.

$ mypy airflow/operators/docker_operator.py
mypy.ini: No [mypy] section in config file
airflow/www/widgets.py:20: error: Cannot find module named 'flask_appbuilder.widgets'

I don't get how this helps with switching branches even ignoring this bug above? Edit okay looked at the rest of the PR and that makes sense. I think we just shouldn't have this empty mypy.ini file, right?

@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 31, 2019

Let me take a look - there should not be mypy.ini in there. But it was in one of my local trials (abandoned). Might be a bad cherry-pick

@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 31, 2019

Oh yeah. Accidentally committed empty mypy.ini when cherry-picked it. Clue of that change was exclusion of www_rbac old folder from find - when you switch between v1-10-test and master branches, this folder remains in your sources and when you mount it in MacOS, scanning the folder takes 30-40 seconds in docker (because of slow osxfs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants