Skip to content

[AIRFLOW-5079] Checklicence test uses own, much smaller image#5692

Merged
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:checklicence-image-separate
Jul 31, 2019
Merged

[AIRFLOW-5079] Checklicence test uses own, much smaller image#5692
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:checklicence-image-separate

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Jul 31, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk potiuk requested review from ashb and mik-laj July 31, 2019 06:37
@ashb
Copy link
Copy Markdown
Member

ashb commented Jul 31, 2019

This will basically never need to be rebuilt right?

Comment thread Dockerfile-checklicence
@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jul 31, 2019

@ashb - correct. There is no need to rebuild it.

@potiuk potiuk merged commit b460e5d into apache:master Jul 31, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Jul 31, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants