Migrate remaining providers to common.compat in apache/drill#57066
Closed
rich7420 wants to merge 1 commit intoapache:mainfrom
Closed
Migrate remaining providers to common.compat in apache/drill#57066rich7420 wants to merge 1 commit intoapache:mainfrom
rich7420 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@kaxil It seems this provider doesn't have a version_compat.py file and it doesn't directly use BaseOperator or BaseHook as well. It uses DbApiHook from common.sql. So I just add common.compat dependency to pyproject.toml. |
Member
|
In that case, we can ignore that drill provider. We only need to add that dep where there is the pattern usage described in the issue. Going to close the PR, feel free to pick other one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace version-specific conditional imports with common.compat layer. This standardizes compatibility handling across Airflow 2.x and 3.x.
This PR is a part of 57018 about apache/drill.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.