Skip to content

Fix mypy type errors in collection.py #57095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 2 commits into from
Oct 23, 2025
Merged

Fix mypy type errors in collection.py #57095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3923c34
Fix: Fix mypy type errors in collection.py
Lzzz666 Oct 22, 2025
dd872ba
Move back Selcet, subquery to type-checking block
Lzzz666 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/dag_processing/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from __future__ import annotations

import traceback
from typing import TYPE_CHECKING, Any, NamedTuple, TypeVar
from typing import TYPE_CHECKING, Any, NamedTuple, TypeVar, cast

import structlog
from sqlalchemy import delete, func, insert, select, tuple_, update
Expand Down Expand Up @@ -444,7 +444,7 @@ def find_orm_dags(self, *, session: Session) -> dict[str, DagModel]:
.options(joinedload(DagModel.schedule_asset_alias_references))
.options(joinedload(DagModel.task_outlet_asset_references))
)
stmt = with_row_locks(stmt, of=DagModel, session=session)
stmt = cast("Select[tuple[DagModel]]", with_row_locks(stmt, of=DagModel, session=session))
return {dm.dag_id: dm for dm in session.scalars(stmt).unique()}

def add_dags(self, *, session: Session) -> dict[str, DagModel]:
Expand Down