Add number of queries guard in public asset list endpoints #57438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
added
the
backport-to-v3-1-test
This was referenced Oct 28, 2025
jscheffl
approved these changes
Oct 29, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for adding this guard!
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 942063a v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 30, 2025
(cherry picked from commit 942063a)
Member
Author
|
Manual backport #57543 |
pierrejeambrun
added a commit
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a pattern we should follow for at least all 'listing' endpoint. Those are subject to db query explosion related to lazy query emitted at serialization time.
This add extra number of queries check for public asset related endpoint.
This allowed to identify a missing loading option too and will prevent future problem if someone add an attribute or a piece of code that create the n+1 queries problem.