Add wildcard support for dag_id and dag_run_id in bulk ti endpoint #57441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:airflow-ctl
area:API
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
4 times, most recently
from
876c23e to
e7e7a33
Compare
guan404ming
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
e7e7a33 to
ce5c6b0
Compare
jason810496
reviewed
Oct 29, 2025
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Show resolved
Hide resolved
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
4 times, most recently
from
6f63537 to
8ef0669
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice.
I just left a comment, I don't have the bandwidth to do an in depth review but overall the direction looks good.
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
3 times, most recently
from
0f044db to
f985133
Compare
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
f985133 to
eaf3cbd
Compare
pierrejeambrun
approved these changes
Dec 2, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
One minor nit but looking good to me.
Lets rebase and fix CI and we should be good to move forward. It's a good base and we can iterate on it if needed.
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
eaf3cbd to
10a25b2
Compare
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
4df6ad7 to
138524e
Compare
jason810496
reviewed
Dec 9, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the update!
Just some nits about query statements then the PR is good to go.
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py
Show resolved
Hide resolved
Member
Author
|
Thanks for the nice suggestion toward the queries. All of them have been updated. |
jason810496
approved these changes
Dec 9, 2025
pierrejeambrun
approved these changes
Dec 9, 2025
airflow-core/src/airflow/api_fastapi/core_api/datamodels/common.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
22a6c9e to
69fbe3b
Compare
pierrejeambrun
approved these changes
Dec 9, 2025
bugraoz93
approved these changes
Dec 9, 2025
guan404ming
force-pushed
the
bulk-ti-wildcard
branch
from
69fbe3b to
e91af57
Compare
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current bulk delete/update endpoint requires making separate N requests when operating across N DAGs, which:
How
Support wildcard (~) matching for dag_id and dag_run_id in bulk task instance API endpoints
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.