Skip to content

[AIRFLOW-5565] Add boto extraArgs to S3Hook load_bytes and load_file_obj#5780

Closed
maxcountryman wants to merge 1 commit intoapache:masterfrom
maxcountryman:patch-2
Closed

[AIRFLOW-5565] Add boto extraArgs to S3Hook load_bytes and load_file_obj#5780
maxcountryman wants to merge 1 commit intoapache:masterfrom
maxcountryman:patch-2

Conversation

@maxcountryman
Copy link
Contributor

This patch allows callers to specify their own ExtraArgs dictionary.

This patch allows callers to specify their own `ExtraArgs` dictionary.
@OmerJog
Copy link
Contributor

OmerJog commented Sep 24, 2019

Please open a Jira ticket (any code change require Jira ticket for tracking) also it needs to be something that people will understand from change log something like:
"Add extraArgs dict to S3Hook".

edit your commit message with :
[AIRFLOW -$JIRANUMBER] Add extraArgs dict to S3Hook

And please add tests to the added functionality

@maxcountryman
Copy link
Contributor Author

@OmerJog please review the change: it should not require additional tests if this module is already tested since it’s just passing down to boto3 and I certainly hope Airflow is not attempting to test boto itself...

If you create the Jira ticket I can update the commit accordingly.

@OmerJog
Copy link
Contributor

OmerJog commented Sep 26, 2019

@feluelle can take a look?

@feluelle
Copy link
Member

feluelle commented Sep 27, 2019

Hey @maxcountryman, I created a Jira Ticket for you.

We currently do not test for the extra_args according to coverage of load_bytes and load_file_obj but I would greatly appreciate it if we do. Because otherwise your change is not guaranteed to work as you expect it to be in the future. :)

Please update the commit message after you've added tests to include the Ticket Id. Thanks.

@feluelle feluelle changed the title allow callers to specify custom ExtraArgs [AIRFLOW-5565] Add boto extraArgs to S3Hook load_bytes and load_file_obj Sep 27, 2019
@feluelle feluelle added the provider:amazon AWS/Amazon - related issues label Sep 28, 2019
@OmerJog
Copy link
Contributor

OmerJog commented Oct 28, 2019

@maxcountryman ping

@stale
Copy link

stale bot commented Dec 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 12, 2019
@stale stale bot closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants