-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Spinner instad or error message when authentication flow waits #58037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Could you help
thanks! |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, needs some update
|
My stamp more on implementation and Turkish translation. I think we might need more eyes on this one |
|
Agreed. Commiters: lets not merge this until we've had more eyes on the translations. |
|
Actually - can you please remove translations? We have been trying this in the past, and the flow where multiple translations are added in the PR are far less likely to "work" and "get more eyes" - that was part of the experiment I've done once. It seems that tit's way better to just add an English version - and let the translator do their translations in separate PRs - possibly "grouped" together with other translations for their language. Our tooling and AI help is making that flow way more efficient and natural. |
Revoking approval to not cause any ambiguity. I agree to delete translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good but that shouldn't be needed. I asked more information on the related issue because I'm unsure why we are observing this at the moment and if this is the appropriate fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this because it's stale. More info are required on the linked issue before we can merge this (because it really shouldn't be needed, so I suspect the root cause might be missed) . This PR looks fine and we can re-open if it appears to be the necessary fix.
Show a localized "Authenticating..." spinner instead of briefly rendering an authentication error during OAuth SSO redirects.
What changed
error.authenticatingi18n key and displays a spinner when the UI detects an OAuth/login flow.error.authenticatingtranslations to several localecommon.jsonfiles.closes: #57981
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.