Skip to content

Conversation

@anjo0511
Copy link

@anjo0511 anjo0511 commented Nov 7, 2025

Show a localized "Authenticating..." spinner instead of briefly rendering an authentication error during OAuth SSO redirects.

What changed

  • The Error page uses the error.authenticating i18n key and displays a spinner when the UI detects an OAuth/login flow.
  • Added error.authenticating translations to several locale common.json files.

closes: #57981


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 7, 2025
@anjo0511 anjo0511 changed the title Authentication spinner #57981 Spinner instad or error message when authentication flow waits #57981 Nov 7, 2025
@guan404ming
Copy link
Member

Could you help

  1. Fix static check error
  2. Attach a demo or screenshot for you change
  3. Add some desciption in PR body for your change

thanks!

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, needs some update

@anjo0511 anjo0511 requested a review from guan404ming November 17, 2025 11:37
bugraoz93
bugraoz93 previously approved these changes Nov 17, 2025
@bugraoz93
Copy link
Contributor

My stamp more on implementation and Turkish translation. I think we might need more eyes on this one

@ashb
Copy link
Member

ashb commented Nov 17, 2025

Agreed. Commiters: lets not merge this until we've had more eyes on the translations.

@potiuk
Copy link
Member

potiuk commented Nov 17, 2025

Actually - can you please remove translations? We have been trying this in the past, and the flow where multiple translations are added in the PR are far less likely to "work" and "get more eyes" - that was part of the experiment I've done once. It seems that tit's way better to just add an English version - and let the translator do their translations in separate PRs - possibly "grouped" together with other translations for their language.

Our tooling and AI help is making that flow way more efficient and natural.

@bugraoz93 bugraoz93 dismissed their stale review November 17, 2025 20:47

Revoking approval to not cause any ambiguity. I agree to delete translations

@pierrejeambrun pierrejeambrun changed the title Spinner instad or error message when authentication flow waits #57981 Spinner instad or error message when authentication flow waits Nov 25, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.4 milestone Nov 25, 2025
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 25, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good but that shouldn't be needed. I asked more information on the related issue because I'm unsure why we are observing this at the moment and if this is the appropriate fix.

@potiuk potiuk modified the milestones: Airflow 3.1.5, Airflow 3.1.6 Dec 14, 2025
@Lee-W Lee-W removed their request for review January 9, 2026 08:14
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this because it's stale. More info are required on the linked issue before we can merge this (because it really shouldn't be needed, so I suspect the root cause might be missed) . This PR looks fine and we can re-open if it appears to be the necessary fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login delay causes false authentication error messages on UI Airflow >=3.1.1

8 participants