Skip to content

Conversation

@messense
Copy link
Member

noop() returns a (code, message) tuple.

`noop()` returns a `(code, message)` tuple.
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 11, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@messense
Copy link
Member Author

The mypy error is confusing? The typeshed for noop() is tuple[int, bytes]

https://github.com/python/typeshed/blob/017aed4dceade7e7dc9880b5182a516e01e135f6/stdlib/smtplib.pyi#L30

while mypy gives:

providers/smtp/src/airflow/providers/smtp/hooks/smtp.py:279: error: "Coroutine[Any, Any, SMTPResponse]" object is not iterable  [misc]
                      status, _message = smtp_client.noop()
                                         ^~~~~~~~~~~~~~~~~~
  Found 1 error in 1 file (checked 4026 source files)

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 2, 2026
@github-actions github-actions bot closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:smtp stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant