Fix: In the log.exception() , the format specifier for the first parameter is missing #58295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich7420
requested review from
ephraimbuddy and
jedcunningham
as code owners
rich7420
changed the title
tirkarthi
approved these changes
Dec 5, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Contributor
Author
|
cc @jason810496 |
Lee-W
reviewed
Jan 20, 2026
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Could we add a unit test for this?
Contributor
Author
|
No problem! |
jason810496
requested changes
Jan 20, 2026
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
The patch LGTM.
Could we add a unit test for this?
I just requested changes, in case someone else accidentally merges it.
rich7420
force-pushed
the
AIRFLOW-58294
branch
from
641f652 to
990a3bd
Compare
Lee-W
approved these changes
Jan 20, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Contributor
Author
|
thanks for the review @Lee-W ! |
jason810496
approved these changes
Jan 20, 2026
jason810496
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…e first parameter is missing (#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- (cherry picked from commit 0e31fcb) Co-authored-by: KUAN-HAO HUANG <101171023+rich7420@users.noreply.github.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 20, 2026
…e first parameter is missing (apache#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- (cherry picked from commit 0e31fcb) Co-authored-by: KUAN-HAO HUANG <101171023+rich7420@users.noreply.github.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Contributor
Author
|
@jason810496 , @Lee-W thanks for the review! |
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
…meter is missing (apache#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 22, 2026
…meter is missing (apache#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
…meter is missing (apache#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
…meter is missing (apache#58295) * fix the format * add a unit test * Update airflow-core/tests/unit/dag_processing/bundles/test_base.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * fix errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #58294
Log message format is incorrect, which may cause log parsing errors or information loss.
This PR modifies the format in log.exception().
airflow/airflow-core/src/airflow/dag_processing/bundles/base.py
Lines 414 to 421 in daf3dee
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.