Skip to content

Conversation

@RoyLee1224
Copy link
Contributor

@RoyLee1224 RoyLee1224 commented Nov 15, 2025

Related

#56325 (comment)

What

  • Add syntax highlighting support to ReactMarkdown code component
  • Centralize SyntaxHighlighter config
  • Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
  • Respect light/dark theme for syntax highlighting

Screenshots

before.mp4
after.mp4

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 15, 2025
@RoyLee1224
Copy link
Contributor Author

cc @Ferdinanddb

Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

@RoyLee1224 RoyLee1224 force-pushed the fix/doc-code branch 2 times, most recently from de5bd23 to 020fb78 Compare November 21, 2025 00:09
…ponents

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting
@pierrejeambrun pierrejeambrun merged commit 76ce1cc into apache:main Nov 24, 2025
60 checks passed
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 24, 2025
github-actions bot pushed a commit that referenced this pull request Nov 24, 2025
* fix: resolve doc code block display issue

* fix: add syntax highlighting to markdown code blocks and refactor components

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting

* fix: modify language register
(cherry picked from commit 76ce1cc)

Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Nov 24, 2025
* fix: resolve doc code block display issue

* fix: add syntax highlighting to markdown code blocks and refactor components

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting

* fix: modify language register
(cherry picked from commit 76ce1cc)

Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
@RoyLee1224 RoyLee1224 deleted the fix/doc-code branch November 29, 2025 02:15
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
* fix: resolve doc code block display issue

* fix: add syntax highlighting to markdown code blocks and refactor components

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting

* fix: modify language register
(cherry picked from commit 76ce1cc)

Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
* fix: resolve doc code block display issue

* fix: add syntax highlighting to markdown code blocks and refactor components

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting

* fix: modify language register
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
* fix: resolve doc code block display issue

* fix: add syntax highlighting to markdown code blocks and refactor components

   - Centralize SyntaxHighlighter config
   - Add syntax highlighting support to ReactMarkdown component
   - Refactor component definitions to module-level to resolve ESLint react/no-unstable-nested-components warning
   - Support multiple languages: Python, JavaScript, TypeScript, JSON, YAML, SQL, Bash
   - Respect light/dark theme for syntax highlighting

* fix: modify language register
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants