Fix google provider false boolean 47053 #58380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where boolean fields set to False in Google provider connection extras were incorrectly returning default values instead. The issue occurred in two places: 1. get_field() function used 'or None' which treated False as falsy 2. _get_field() method used compound boolean logic that returned the default value when the actual value was False This particularly affected BigQueryHook where use_legacy_sql=False in connection extras would incorrectly return True. Changes: - Modified get_field() to only treat empty strings as None - Modified _get_field() to explicitly check 'is not None' - Added tests for False/falsy value handling Fixes apache#47053
Update mock paths from 'airflow.hooks.base.BaseHook' to 'airflow.providers.common.compat.sdk.BaseHook' to match the new import structure in Airflow 3.x.
Use sentinel pattern to distinguish unset parameters from explicitly False values, allowing both connection extras and parameter overrides to work correctly.
Contributor
Author
|
opened by mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.