Use lazy imports for callback and deadline SDK definitions #58506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
reviewed
Nov 20, 2025
ramitkataria
force-pushed
the
ramitkataria/deadlines/callback-import-docs-update
branch
from
1462781 to
56740ba
Compare
ramitkataria
changed the title
amoghrajesh
reviewed
Dec 4, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
ramitkataria
force-pushed
the
ramitkataria/deadlines/callback-import-docs-update
branch
2 times, most recently
from
20d0376 to
318ef74
Compare
Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
ramitkataria
force-pushed
the
ramitkataria/deadlines/callback-import-docs-update
branch
from
318ef74 to
664c8e9
Compare
Contributor
Author
|
cc @ferruzzi |
github-actions
bot
removed
the
stale
ferruzzi
approved these changes
Jan 22, 2026
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
LGTM I think, once the static checks are green
amoghrajesh
approved these changes
Jan 22, 2026
amoghrajesh
approved these changes
Jan 22, 2026
ferruzzi
deleted the
ramitkataria/deadlines/callback-import-docs-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback definitions in TaskSDK were moved to their own module in #58177 causing existing Dags using
AsyncCallbackto fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.