Skip to content

[AIRFLOW-5252] Move GCP Transfer to core#5858

Merged
milton0825 merged 1 commit intoapache:masterfrom
PolideaInternal:gcp-data-transfer
Aug 20, 2019
Merged

[AIRFLOW-5252] Move GCP Transfer to core#5858
milton0825 merged 1 commit intoapache:masterfrom
PolideaInternal:gcp-data-transfer

Conversation

@turbaszek
Copy link
Member

This commit moves GCP Transfer from contrib to core.
For more information check AIP-21.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This commit moves GCP Transfer from contrib to core. For more information check AIP-21.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

This commit moves GCP Transfer from contrib to core.
For more information check AIP-21.
@milton0825 milton0825 merged commit da582d5 into apache:master Aug 20, 2019
@hagope
Copy link
Contributor

hagope commented Aug 27, 2019

Hi @nuclearpinguin, I'm thinking of coding some operators for Gsheets. For example,
GoogleCloudStorageToGsheetsTransferOperator
GsheetsToGoogleCloudStorageTransferOperator
S3ToGsheetsTransferOperator
GsheetsToS3TransferOperator

Few questions, 1.) is it a good idea? 2.) should we do it in cloud_storage_transfer_service.py or should there be a new gsheets.py files that implements operators for gsheets... also share any ideas for gsheet operators you think may be useful.

@mik-laj
Copy link
Member

mik-laj commented Aug 27, 2019

Hi.

We should use Gcs instead GoogleCloudStorage. My have prepared change plans for all GCP to have unified name. The plan has been approved by Google. In the near future we will introduce changes.

It should be new file gcs_to_gsheets.py.

cloud_storage_transfer_service.py contains integration to Google service that allow create transfer job, so it not transfer operator. It's operator that perform action in external service.
https://cloud.google.com/products/data-transfer/

Have you read the GCP Integration guide? this is an amazing source of knowledge about operator names.

@mik-laj
Copy link
Member

mik-laj commented Aug 27, 2019

I think, you will be interested in this operator also:
#5822

Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
This commit moves GCP Transfer from contrib to core.
For more information check AIP-21.
@turbaszek turbaszek deleted the gcp-data-transfer branch September 19, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants