Convert check_translation_completeness.py into breeze command#58637
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 24, 2025
Merged
Conversation
potiuk
requested review from
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
ephraimbuddy,
gopidesupavan,
guan404ming,
jason810496,
jedcunningham,
jscheffl,
kaxil,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:dev-tools
area:translations
area:UI
The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script.
potiuk
force-pushed
the
move-check-translation-completeness-to-breeze
branch
from
28e91c7 to
14928c1
Compare
jscheffl
approved these changes
Nov 24, 2025
bugraoz93
approved these changes
Nov 24, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Nice, always good and easier to have them in Breeze!
Contributor
|
Will check the translation gaps soon |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 60034e1 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 24, 2025
…ommand (apache#58637) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script. (cherry picked from commit 60034e1) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 24, 2025
…ommand (apache#58637) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script. (cherry picked from commit 60034e1) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Nov 25, 2025
…ommand (#58637) (#58654) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script. (cherry picked from commit 60034e1)
Member
Author
|
Backport #58654 |
Member
|
Coool ;) |
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…ommand (#58637) (#58654) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script. (cherry picked from commit 60034e1)
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…he#58637) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script.
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…he#58637) The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command. Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect: * it sorts character-by-character case-insensitive * it uses original sorting as tie-breker in case of characters case-insensitve order * handles numbers natuarlly (2<10) * treats _ as end of word and sort it before everything else * similarly with end of word - shorter words are before longer if they have the same prefix This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script had no good support for auto-complete and the like and since everyone now use breeze for some tasks, we also should have it as a regular breeze command.
Also the sorting order implemented by eslint jsonc natural sorting was quite a bit different from what you'd expect:
This PR updates the command and also fixes sorting order and add unit tests to test vital parts of the translation script.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.