[WIP]feat(i18n): add tool to detect unused translation keys#58661
Closed
RoyLee1224 wants to merge 1 commit intoapache:mainfrom
Closed
[WIP]feat(i18n): add tool to detect unused translation keys#58661RoyLee1224 wants to merge 1 commit intoapache:mainfrom
RoyLee1224 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As the Airflow UI grows, translation files accumulate keys that are no longer used in the source code. This tool helps developers maintain the cleanliness of translation files.
Note: I'm marking this as a draft since this is just the first phase. The code has not yet been refactored, and the detection logic still needs some improvement. Feedback and discussion are welcome!
Key Features
.tsand.tsxfiles inairflow/uito find usages oftranslate().state.${taskState}expands tostate.success,state.failed, etc.).up,down, etc.).task_one,task_other).dev/breeze/doc/breeze_ui.rstand added the command output screenshot.Implementation Details
en/*.jsonagainst the keys found in the source code.Screenshots
I've verified that these keys in

admin.jsonandassets.jsonare indeed unused. (FornameMaxLength, it's a key mismatch.)The detection logic for dynamic key in

common.jsonstill needs some refinement. However, I can confirm that at least keys likeallOperatorsandlogicalDateFromare unused and should be removed.While the detection isn't 100% precise yet, it effectively isolates the potential candidates. Finding these unused keys manually would have been nearly impossible.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.