-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix typos and improve phrasing in unit testing guide #58765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and improve phrasing in unit testing guide #58765
Conversation
Parkerhiphop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left examples for explaining the changes.
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Super useful!
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
4bc2f8a to
8a68b2d
Compare
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker ea9e1ec v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
While reading the testing guide, I noticed some technical inaccuracies in the code examples and instructions.
Key Technical Fixes:
pytest.warn→pytest.warns: Corrected the reference to the context manager.@pytest.mark.db, but the code examples and actual usage allow for@pytest.mark.db_test. I have standardized this to avoid confusion.(I have left inline comments on these specific lines to highlight them.)