Skip to content

Conversation

@Parkerhiphop
Copy link
Contributor

@Parkerhiphop Parkerhiphop commented Nov 27, 2025

While reading the testing guide, I noticed some technical inaccuracies in the code examples and instructions.

Key Technical Fixes:

  • pytest.warnpytest.warns : Corrected the reference to the context manager.
  • Marker Consistency: Fixed inconsistent usage of markers. The text previously referred to @pytest.mark.db, but the code examples and actual usage allow for @pytest.mark.db_test. I have standardized this to avoid confusion.
  • Typos: Fixed obvious typos (e.g., "Herr id" → "Here is").

(I have left inline comments on these specific lines to highlight them.)

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Nov 27, 2025
Copy link
Contributor Author

@Parkerhiphop Parkerhiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left examples for explaining the changes.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Super useful!

Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
@potiuk potiuk force-pushed the fix-unit-testing-guide-typos branch from 4bc2f8a to 8a68b2d Compare November 28, 2025 16:30
@potiuk potiuk merged commit ea9e1ec into apache:main Nov 29, 2025
118 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker ea9e1ec v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Refined the English grammar throughout the document to make it more natural and professional. Fixed specific issues like "That mean" -> "This means" and corrected various formatting inconsistencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants