Skip to content

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Nov 29, 2025

False positive tests related: #58701 (comment)

  • dags update removed because we have pause/unpause
  • dagrun delete wrongly added which doesn't exists
    Handle the missing case for like below
 Running command: dagrun get --dag-id=example_bash_operator --dagrun-id=manual__2025-09-25T01:02:21+00:00
  ✅ Output did not contain unexpected text for command 'airflowctl dagrun get --dag-id=example_bash_operator --dagrun-id=manual__2025-09-25T01:02:21+00:00'
  Result:
  airflowctl command error: unrecognized arguments: --dagrun-id=manual__2025-09-25T01:02:21+00:00, see help above.
  Usage: airflowctl [-h] GROUP_OR_COMMAND ...
  
  Positional Arguments:
    GROUP_OR_COMMAND
  
      Groups
        assets        Perform Assets operations
        auth          Manage authentication for CLI. Either pass token from
                      environment variable/parameter or pass username and
                      password.
        backfill      Perform Backfill operations
        config        Perform Config operations
        connections   Perform Connections operations
        dagrun        Perform DagRun operations
        dags          Perform Dags operations
        jobs          Perform Jobs operations
        pools         Perform Pools operations
        providers     Perform Providers operations
        variables     Perform Variables operations
  
      Commands:
        version       Show version information
  
  Options:
    -h, --help        show this help message and exit

OR

 ✅ Output did not contain unexpected text for command 'airflowctl dagrun delete --dag-id=example_bash_operator --dagrun-id=manual__2025-09-25T01:02:21+00:00'
  Result:
  airflowctl dagrun command error: argument COMMAND: invalid choice: 'delete' (choose from 'get', 'list'), see help above.
  Usage: airflowctl dagrun [-h] COMMAND ...
  
  Perform DagRun operations
  
  Positional Arguments:
    COMMAND
      get       Perform get operation
      list      Perform list operation
  
  Options:
    -h, --help  show this help message and exit

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@bugraoz93 bugraoz93 changed the title Handle unrecognized arguments for airflowctl command output Handle unrecognized arguments for airflowctl integration tests Nov 29, 2025
@bugraoz93 bugraoz93 added the full tests needed We need to run full set of tests for this PR to merge label Nov 29, 2025
@bugraoz93 bugraoz93 closed this Nov 29, 2025
@bugraoz93 bugraoz93 reopened this Nov 29, 2025
@bugraoz93 bugraoz93 changed the title Handle unrecognized arguments for airflowctl integration tests Handle false positive tests for airflowctl integration tests Nov 29, 2025
@bugraoz93 bugraoz93 force-pushed the unrecognized-argument-airflowctl-integration branch from 2a5830c to 5a05982 Compare November 29, 2025 23:53
@bugraoz93
Copy link
Contributor Author

will fix static checks once we see the integration tests green to not spend more resources

@bugraoz93
Copy link
Contributor Author

@potiuk potiuk merged commit b89ab85 into apache:main Nov 30, 2025
118 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
…58859)

* Handle unrecognized arguments for airflowctl command output

* Update tests accordingly

* Refactor airflowctl command error handling and improve test stability

* Correct order of dagrun list command in tests to increase stability

* Fix missing newline at end of pools_export.json
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…58859)

* Handle unrecognized arguments for airflowctl command output

* Update tests accordingly

* Refactor airflowctl command error handling and improve test stability

* Correct order of dagrun list command in tests to increase stability

* Fix missing newline at end of pools_export.json
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
…58859)

* Handle unrecognized arguments for airflowctl command output

* Update tests accordingly

* Refactor airflowctl command error handling and improve test stability

* Correct order of dagrun list command in tests to increase stability

* Fix missing newline at end of pools_export.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants