Fix exception when logging stdout with a custom %-fmt string. #58959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, if you set this config
```ini
[logging]
log_format={%%(filename)s:%%(lineno)d} --- %%(message)s
```
this would blow up with an error like this on printing anything from a
trigger, killing the triggerer process:
```
2025-11-03 14:13:27 File "/usr/local/lib/python3.12/site-packages/airflow/_shared/logging/percent_formatter.py", line 149, in __call__
2025-11-03 14:13:27 sio.write(self._fmt % params)
2025-11-03 14:13:27 ~~~~~~~~~~^~~~~~~~
2025-11-03 14:13:27 TypeError: %d format: a real number is required, not NoneType
```
ashb
added
the
backport-to-v3-1-test
shahar1
approved these changes
Dec 2, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…ing. (#58959) For instance, if you set this config ```ini [logging] log_format={%%(filename)s:%%(lineno)d} --- %%(message)s ``` this would blow up with an error like this on printing anything from a trigger, killing the triggerer process: ``` 2025-11-03 14:13:27 File "/usr/local/lib/python3.12/site-packages/airflow/_shared/logging/percent_formatter.py", line 149, in __call__ 2025-11-03 14:13:27 sio.write(self._fmt % params) 2025-11-03 14:13:27 ~~~~~~~~~~^~~~~~~~ 2025-11-03 14:13:27 TypeError: %d format: a real number is required, not NoneType ``` (cherry picked from commit 586fe93) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 2, 2025
…ing. (apache#58959) For instance, if you set this config ```ini [logging] log_format={%%(filename)s:%%(lineno)d} --- %%(message)s ``` this would blow up with an error like this on printing anything from a trigger, killing the triggerer process: ``` 2025-11-03 14:13:27 File "/usr/local/lib/python3.12/site-packages/airflow/_shared/logging/percent_formatter.py", line 149, in __call__ 2025-11-03 14:13:27 sio.write(self._fmt % params) 2025-11-03 14:13:27 ~~~~~~~~~~^~~~~~~~ 2025-11-03 14:13:27 TypeError: %d format: a real number is required, not NoneType ``` (cherry picked from commit 586fe93) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ashb
pushed a commit
that referenced
this pull request
Dec 2, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
…#58959) For instance, if you set this config ```ini [logging] log_format={%%(filename)s:%%(lineno)d} --- %%(message)s ``` this would blow up with an error like this on printing anything from a trigger, killing the triggerer process: ``` 2025-11-03 14:13:27 File "/usr/local/lib/python3.12/site-packages/airflow/_shared/logging/percent_formatter.py", line 149, in __call__ 2025-11-03 14:13:27 sio.write(self._fmt % params) 2025-11-03 14:13:27 ~~~~~~~~~~^~~~~~~~ 2025-11-03 14:13:27 TypeError: %d format: a real number is required, not NoneType ```
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…#58959) For instance, if you set this config ```ini [logging] log_format={%%(filename)s:%%(lineno)d} --- %%(message)s ``` this would blow up with an error like this on printing anything from a trigger, killing the triggerer process: ``` 2025-11-03 14:13:27 File "/usr/local/lib/python3.12/site-packages/airflow/_shared/logging/percent_formatter.py", line 149, in __call__ 2025-11-03 14:13:27 sio.write(self._fmt % params) 2025-11-03 14:13:27 ~~~~~~~~~~^~~~~~~~ 2025-11-03 14:13:27 TypeError: %d format: a real number is required, not NoneType ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, if you set this config
this would blow up with an error like this on printing anything from a
trigger, killing the triggerer process:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.