Skip to content

Conversation

@jstaf
Copy link
Contributor

@jstaf jstaf commented Dec 4, 2025

One of our data analysts found a novel way to crash Airflow's dag-processor by uploading an Excel file to Airflow's DAG directory! Normally, Airflow should print a warning message and say that the Excel file is an invalid zip file (MS Office .xlsx/.docx/etc. documents are all zip archives). In this case however, Airflow has the wrong number of %ss when logging the warning, which causes Airflow's dag-processor to crash when handling the zipfile.BadZipFile exception. This PR fixes the crash by fixing the warning message to have the correct number of %ss in its format string.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 7, 2025
@potiuk potiuk merged commit 5c41f2e into apache:main Dec 7, 2025
68 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 7, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Dec 7, 2025
…n the DAG directory (#59069)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

jscheffl pushed a commit that referenced this pull request Dec 7, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Dec 8, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 8, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 8, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 8, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 8, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 8, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
@jstaf jstaf deleted the patch-1 branch December 8, 2025 20:25
ephraimbuddy pushed a commit that referenced this pull request Dec 9, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 11, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 12, 2025
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
…n the DAG directory (#59069) (#59170)

(cherry picked from commit 5c41f2e)

Co-authored-by: Jeff Stafford <jeff.stafford@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:DAG-processing backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants