-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Prevent dag-processor crash on encountering Excel files in the DAG directory #59069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
One of our data analysts found a novel way to crash Airflow's dag-processor by uploading an Excel file to Airflow's DAG directory! Normally, Airflow should print a warning message and say that the Excel file is an invalid zip file (MS Office .xlsx/.docx/etc. documents are all zip archives). In this case however, Airflow has the wrong number of
%ss when logging the warning, which causes Airflow's dag-processor to crash when handling thezipfile.BadZipFileexception. This PR fixes the crash by fixing the warning message to have the correct number of%ss in its format string.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.