Skip to content

Add todo re exception handling in dagrun create loop #59121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstandish merged 2 commits into from
Dec 11, 2025
Merged

Add todo re exception handling in dagrun create loop #59121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33aade
Add todo re exception handling in dagrun create loop
dstandish Dec 5, 2025
313f47e
Merge branch 'main' into add-todo-for-scheduler-exc-handling
dstandish Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airflow-core/src/airflow/jobs/scheduler_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1831,6 +1831,10 @@ def _create_dag_runs(self, dag_models: Collection[DagModel], session: Session) -
# and continue to the next serdag.
except Exception:
self.log.exception("Failed creating DagRun for %s", serdag.dag_id)
# todo: continuing here does not work because session needs rollback
# but you need either to make smaller transactions and commit after every dag run
# or to use savepoints.
# https://github.com/apache/airflow/issues/59120
continue
if self._should_update_dag_next_dagruns(
serdag,
Expand Down