-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Adding Japanese translations for UI (i18n) #59313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooohoooe
|
Technical approval - but would be great for people who speak Japanese to review: @sekikn Maybe :) |
|
WOW, it’s great to see a neighboring country language being added🙌 You can add and remove keys using a command like this 😉 |
896e247 to
37827bb
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the small gaps looks very good. But to further maintain we should also adjust the .github/CODEOWNERS and describe who would be sponsor as committer and who would be engaged translator. Can you add this? Would you volunteer yourself to be the engaged translator?
残念ながら日本語は話せませんが、Google翻訳を使って翻訳を試しています。小さな欠落を除けば、非常に良さそうです。しかし、さらにメンテナンスを行うためには、.github/CODEOWNERS を編集し、誰がコミッターとしてスポンサーとなり、誰が翻訳者として関与するかを記載する必要があります。この情報を追加していただけますか?ご自身で翻訳者として関与していただけますか?
|
Thank you for the review and advice everyone! Regarding |
|
Thank you all. Thanks again. |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the CODEOWNERS file. (translation owners + sponsors)
Code looks good.
Can't vouch for the translation
…ranslations, removed extra translations, and not keeping Providers as it is (in English).
37827bb to
8231440
Compare
choo121600
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gooood 🙌
|
All important tests passed :). Merging. Congrats on 100% completion of Japanese :D WOOOHOOO!!!! 🗾 |
|
The failing tests is fixed in main already. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 93454f0 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
No backporting needed . |
|
Just to Add - No backporting needed - unless you would like to contribute it to v3-1-test -> some small changes will be needed as set of features is abit different in v3-1-test @rsanda . You could open a new pr wiht those changes towards |
* Adding Japanese translations for UI * Response to comments on PR#59313. Updated CODEOWNERS, added missing translations, removed extra translations, and not keeping Providers as it is (in English).

This PR contains the translations for Japanese as proposed in the following mail.
https://lists.apache.org/thread/wdys3tnfx7vnhv350bwcbcmoc52h3yyd
This is the first time I'm contributing to Airflow. So, if I am doing something wrong, please feel free to point it out. 😅
Looking forward to hearing your feedback!
Best,
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.