Skip to content

Add toaster notifications for Connection Test #59354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 2 commits into from
Dec 12, 2025
Merged

Add toaster notifications for Connection Test #59354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5aabb8
Add toaster notifications for Test Connection
choo121600 Dec 11, 2025
e54258d
refactor: move test connection translations to admin.json
choo121600 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions airflow-core/src/airflow/ui/public/i18n/locales/en/admin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@
"searchPlaceholder": "Search Connections",
"test": "Test Connection",
"testDisabled": "Test connection feature is disabled. Please contact an administrator to enable it.",
"testError": {
"title": "Test Connection Failed"
},
"testSuccess": {
"title": "Test Connection Successful"
},
"typeMeta": {
"error": "Failed to retrieve Connection Type Meta",
"standardFields": {
Expand Down
21 changes: 20 additions & 1 deletion airflow-core/src/airflow/ui/src/queries/useTestConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,31 @@
* under the License.
*/
import type { Dispatch, SetStateAction } from "react";
import { useTranslation } from "react-i18next";

import { useConnectionServiceTestConnection } from "openapi/queries";
import type { ConnectionTestResponse } from "openapi/requests/types.gen";
import { toaster } from "src/components/ui";

export const useTestConnection = (setConnected: Dispatch<SetStateAction<boolean | undefined>>) => {
const onSuccess = (res: ConnectionTestResponse) => setConnected(res.status);
const { t: translate } = useTranslation("admin");

const onSuccess = (res: ConnectionTestResponse) => {
setConnected(res.status);
if (res.status) {
toaster.create({
description: res.message,
title: translate("connections.testSuccess.title"),
type: "success",
});
} else {
toaster.create({
description: res.message,
title: translate("connections.testError.title"),
type: "error",
});
}
};

const onError = () => {
setConnected(false);
Expand Down