Skip to content

Fix message of _read_from_logs_server when status_code is 403 #59489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Dec 16, 2025
Merged

Fix message of _read_from_logs_server when status_code is 403 #59489

potiuk merged 1 commit into from
Dec 16, 2025

Conversation

@nhuantho
Copy link
Contributor

@nhuantho nhuantho commented Dec 16, 2025

What

  • Version: 3.1.5
  • This message is suitable for airflow version < 3.0, but the architecture was changed, webserver was changed to api-server, and dag-processor was added. So I want to change the message correctly.
image

How:

  • Change webservers to api-servers.
  • Add dag-processors to this message.
  • Change webserver to [api].

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 16, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jason810496 jason810496 self-requested a review December 16, 2025 05:04
@jason810496 jason810496 added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Dec 16, 2025
jason810496
jason810496 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@potiuk potiuk merged commit 97b30f4 into apache:main Dec 16, 2025
70 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 16, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Dec 16, 2025
@nhuantho
[v3-1-test] Fix message of _read_from_logs_server when status_code is…
ea6b581 
… 403 (#59489)

(cherry picked from commit 97b30f4)

Co-authored-by: nhuantho <91556274+nhuantho@users.noreply.github.com>
Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Dec 16, 2025
@nhuantho
[v3-1-test] Fix message of _read_from_logs_server when status_code is…
d49116a 
… 403 (apache#59489)

(cherry picked from commit 97b30f4)

Co-authored-by: nhuantho <91556274+nhuantho@users.noreply.github.com>
Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
potiuk pushed a commit that referenced this pull request Dec 16, 2025
@github-actions @nhuantho
[v3-1-test] Fix message of _read_from_logs_server when status_code is…
a3bbd8f 
… 403 (#59489) (#59504)

(cherry picked from commit 97b30f4)

Co-authored-by: nhuantho <91556274+nhuantho@users.noreply.github.com>
Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
FoxHelms pushed a commit to FoxHelms/airflow that referenced this pull request Dec 17, 2025
@nhuantho @FoxHelms
Fix message of _read_from_logs_server when status_code is 403 (apache…
3555962 
…#59489)

Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
@nhuantho nhuantho deleted the core/log/fix-file_task_handler branch December 23, 2025 16:23
TempestShaw pushed a commit to TempestShaw/airflow that referenced this pull request Dec 24, 2025
@nhuantho @TempestShaw
Fix message of _read_from_logs_server when status_code is 403 (apache…
ff2cd96 
…#59489)

Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
@github-actions @nhuantho @ephraimbuddy
[v3-1-test] Fix message of _read_from_logs_server when status_code is…
f22c766 
… 403 (#59489) (#59504)

(cherry picked from commit 97b30f4)

Co-authored-by: nhuantho <91556274+nhuantho@users.noreply.github.com>
Co-authored-by: nhuan.bc <nhuan.bc@teko.vn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@jason810496 jason810496 jason810496 approved these changes

Assignees

No one assigned

Labels

area:logging backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nhuantho @potiuk @jason810496