Skip to content

Conversation

@bgshacklett
Copy link
Contributor

While creating a small PR to the documentation, I ran into some difficulty with the pre-commit configuration. In particular, there were missing dependencies for the prek scripts. This PR aims to fix that issue.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 17, 2025
@bgshacklett bgshacklett force-pushed the chore/precommit-config branch from 11bebb9 to 932c87f Compare December 17, 2025 14:23
@potiuk
Copy link
Member

potiuk commented Dec 17, 2025

While creating a small PR to the documentation, I ran into some difficulty with the pre-commit configuration. In particular, there were missing dependencies for the prek scripts. This PR aims to fix that issue.

You should switch to prek instead. Requirements are stored in the scripts as "inline-metadata" https://packaging.python.org/en/latest/specifications/inline-script-metadata/ - and prek already supports them, while pre-commit does not. We do not want to duplicate those dependencies and keep pre-commit compatibility.

Our contributing docs have been updated to reflect that - only prek is supported now.

Also prekl supports workspaces in monorepo - and we are in progress of splitting our configuration files among subdirectories (we have now 11 .pre-commit-config.yaml files).

This have been discussed and announced here: https://lists.apache.org/thread/dzs4s8wr8jd7q5r3lvcov2nhqpgt1031

Simply - switch to prek.

@potiuk potiuk closed this Dec 17, 2025
@bgshacklett bgshacklett deleted the chore/precommit-config branch December 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants