Fix test_date_timezone_omitted by patching correct timezone attribute to fix CI #59698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles]
sunank200
added
full tests needed
steveahnahn
approved these changes
Dec 22, 2025
uranusjr
approved these changes
Dec 22, 2025
amoghrajesh
approved these changes
Dec 22, 2025
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 3d33d6d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
sunank200
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 22, 2025
…apache#59698) The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles] (cherry picked from commit 3d33d6d)
sunank200
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 22, 2025
…apache#59698) The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles] (cherry picked from commit 3d33d6d)
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
…apache#59698) The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles]
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…apache#59698) The test was failing because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses _Timezone.initialized_timezone to store the default timezone, which is what the parse function uses when parsing timestamps without timezone information. Fixes failing tests: - TestCLIDBClean.test_date_timezone_omitted[UTC] - TestCLIDBClean.test_date_timezone_omitted[Europe/Berlin] - TestCLIDBClean.test_date_timezone_omitted[America/Los_Angeles]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is failing here because it tried to patch a non-existent TIMEZONE attribute. The timezone module uses
_Timezone.initialized_timezoneto store the default timezone.Fix: Updated the test to patch the correct attribute used by the parse function.
Root cause: PR #59689 replaced the global TIMEZONE variable with _Timezone.initialized_timezone, breaking the test that was patching the wrong attribute.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.