Add E2E tests for DAG audit log functionality (#59684) #59734

haseebmalik18 · 2025-12-23T04:44:09Z

Add E2E tests for DAG audit log functionality

This PR implements comprehensive end-to-end tests for the DAG audit log feature to ensure proper functionality of the Events tab.

Changes

New Files

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts - Page Object Model for the Events/audit log page
airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts - E2E test specifications

Test Coverage

The implementation includes 5 test scenarios covering:

Navigation and Table Visibility - Verifies users can navigate to the audit log tab and the table renders correctly
Column Verification - Ensures all expected columns (When, Event, User, Extra) are displayed and DAG ID column is hidden in DAG-specific context
Data Validation - Validates that audit log entries contain valid data with proper null/edge case handling
Pagination - Tests navigation between pages and verifies content changes appropriately
Sorting - Validates column header sorting functionality

Implementation Details

Follows existing Page Object Model patterns from DagsPage.ts
Uses data-testid selectors for stable test automation
Includes proper error handling and edge case coverage (empty data, no pagination, insufficient rows)
All code passes ESLint with strict alphabetical sorting requirements (perfectionist/sort-classes)
Follows TypeScript strict mode conventions

closes: #59684

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

boring-cyborg · 2025-12-23T04:44:12Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

vatsrahul1001 · 2025-12-23T09:36:16Z

@haseebmalik18 can you look at failures?

haseebmalik18 · 2025-12-23T22:08:32Z

Yes, I've taken a look I understand what the issue is I will have it in a day or two

haseebmalik18 · 2025-12-25T22:34:12Z

@vatsrahul1001 Just made the fixes. Should be good now.

vatsrahul1001 · 2025-12-28T13:08:00Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

+    const sortButton = columnHeader.locator('button[aria-label="sort"]');
+
+    await sortButton.click();
+    await this.page.waitForTimeout(2000);


Instead of hardcoding wait. We can wait for specific condition (table reload, URL change) instead.

vatsrahul1001 · 2025-12-28T13:09:05Z

airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts

+    const setupDagsPage = new DagsPage(page);
+    const setupEventsPage = new EventsPage(page);
+
+    for (let i = 0; i < 10; i++) {


Very slow (could take 70+ minutes with 7-minute timeout per trigger)
If one trigger fails, all tests fail
We can Reduce to 2-3 triggers

vatsrahul1001 · 2025-12-28T13:09:23Z

airflow-core/src/airflow/ui/tests/e2e/pages/EventsPage.ts

+
+      return true;
+    } catch {
+      return false;


Methods like isAuditLogTableVisible(), hasNextPage(), getEventLogCount() catch errors and return false This makes debugging difficult and can cause tests to pass when they shouldn't.

vatsrahul1001 · 2025-12-28T13:09:37Z

airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts

+
+    const hasNext = await eventsPage.hasNextPage();
+
+    if (hasNext) {


If pagination isn't available, test passes without testing anything.

Hi @vatsrahul1001 , I've addressed all your feedback. But, I'm not sure how to approach the pagination test without increasing triggers. The problem is that 3 triggers only creates 4 audit log events, but I need 51+ events to test pagination since production default is page_size=50. I'm not quite sure how to approach this as increasing the trigger will be quite slow. Any suggestions?

vatsrahul1001 · 2025-12-28T13:10:08Z

airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts

+        const allTextContents = await cells.allTextContents();
+        const hasContent = allTextContents.some((text) => text.trim().length > 0);
+
+        expect(hasContent).toBe(true);


Just checks "something exists" - doesn't verify actual event data like event type, timestamp format, etc.

vatsrahul1001 · 2025-12-28T13:10:21Z

airflow-core/src/airflow/ui/tests/e2e/specs/dag-audit-log.spec.ts

+
+    const orderChanged = JSON.stringify(initialEvents) !== JSON.stringify(sortedEvents);
+
+    expect(orderChanged).toBe(true);


Only checks order changed, not that it's correctly sorted. Could pass even if sorting is broken.

vatsrahul1001 · 2025-12-28T13:10:58Z

airflow-core/src/airflow/ui/tests/e2e/pages/DagsPage.ts

   */
  public async clickNextPage(): Promise<void> {
    await this.paginationNextButton.click();
-    await this.waitForDagList();


Removing waitForDagList() could break other tests that depend on pagination. Why was this changed?

vatsrahul1001 · 2026-01-05T09:57:50Z

@haseebmalik18 can you look at review comments?

haseebmalik18 · 2026-01-05T13:59:22Z

@vatsrahul1001 The E2E test for audit log pagination currently creates 4 events via 3 DAG triggers, but the UI config sets page_size: 15, so pagination won't trigger. To properly test pagination, we'd need 16+ events, which would require ~14+ DAG triggers which would be quite slow. What would you say is the recommended approach for generating event logs to generate pagination direct DB inserts, lower page_size config for tests, or another method?

Add E2E tests for DAG audit log functionality (apache#59684)

b2844a0

haseebmalik18 requested a review from vatsrahul1001 as a code owner December 23, 2025 04:44

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 23, 2025

Merge branch 'main' into main

4cdcbad

haseebmalik18 and others added 2 commits December 25, 2025 17:30

Add E2E tests for DAG audit log functionality apache#59684

66f1251

Merge branch 'main' into main

9df2836

vatsrahul1001 and others added 3 commits December 28, 2025 12:49

Merge branch 'main' into main

4604abf

Add E2E tests for DAG audit log functionality apache#59684

3dbc6fc

Merge branch 'main' of https://github.com/haseebmalik18/airflow

26b0de8

vatsrahul1001 reviewed Dec 28, 2025

View reviewed changes


		const hasNext = await eventsPage.hasNextPage();

		if (hasNext) {


		const orderChanged = JSON.stringify(initialEvents) !== JSON.stringify(sortedEvents);

		expect(orderChanged).toBe(true);

Add E2E tests for DAG audit log functionality (#59684) #59734

Are you sure you want to change the base?

Add E2E tests for DAG audit log functionality (#59684) #59734

Conversation

haseebmalik18 commented Dec 23, 2025

Changes

New Files

Test Coverage

Implementation Details

Uh oh!

boring-cyborg bot commented Dec 23, 2025

Uh oh!

vatsrahul1001 commented Dec 23, 2025

Uh oh!

haseebmalik18 commented Dec 23, 2025

Uh oh!

haseebmalik18 commented Dec 25, 2025

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

haseebmalik18 Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

vatsrahul1001 commented Jan 5, 2026

Uh oh!

haseebmalik18 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

haseebmalik18 Dec 28, 2025 •

edited

Loading

haseebmalik18 commented Jan 5, 2026 •

edited

Loading