Skip to content

Fix flaky tests related to github api rate limits #59879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jscheffl merged 1 commit into from
Dec 29, 2025
Merged

Fix flaky tests related to github api rate limits #59879

jscheffl merged 1 commit into from
Dec 29, 2025

Conversation

@Dev-iL
Copy link
Collaborator

@Dev-iL Dev-iL commented Dec 29, 2025

Context

https://github.com/apache/airflow/actions/runs/20565295970/job/59062570817#step:5:2745

FAILED tests/test_selective_checks.py::test_expected_output_push[All tests run on push even if unimportant file changed] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_expected_output_push[All tests except Providers and Helm run on push even if unimportant file changed in non-main branch] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_expected_output_push[All tests run on push if core file changed] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_no_commit_provided_trigger_full_build_for_any_event_type[GithubEvents.PUSH] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_no_commit_provided_trigger_full_build_for_any_event_type[GithubEvents.SCHEDULE] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_files_provided_trigger_full_build_for_any_event_type[GithubEvents.PUSH] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
FAILED tests/test_selective_checks.py::test_files_provided_trigger_full_build_for_any_event_type[GithubEvents.SCHEDULE] - requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Fix details

  • Don't try to access the json of a non-200 response.
  • Replace API calls with mocks.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 29, 2025
@Dev-iL Dev-iL force-pushed the 2512/fix_flaky_selective branch from 708b4ce to de26997 Compare December 29, 2025 08:16
uranusjr
uranusjr reviewed Dec 29, 2025
View reviewed changes
uranusjr
uranusjr approved these changes Dec 29, 2025
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested otherwise looks good to me

amoghrajesh
amoghrajesh approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@Dev-iL
Fix flaky tests related to github api rate limits
a9b832d 
- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
@Dev-iL Dev-iL force-pushed the 2512/fix_flaky_selective branch from de26997 to a9b832d Compare December 29, 2025 10:50
@jscheffl jscheffl merged commit dae3441 into apache:main Dec 29, 2025
126 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 29, 2025
@Dev-iL
[v3-1-test] Fix flaky tests related to github api rate limits (#59879)
adefe0d 
- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
(cherry picked from commit dae3441)

Co-authored-by: Dev-iL <6509619+Dev-iL@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Backport successfully created: v3-1-test

Status Branch Result
✅ v3-1-test PR Link

jscheffl pushed a commit that referenced this pull request Dec 29, 2025
@github-actions @Dev-iL
[v3-1-test] Fix flaky tests related to github api rate limits (#59879) (
4256cc3 
#59884)

- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
(cherry picked from commit dae3441)

Co-authored-by: Dev-iL <6509619+Dev-iL@users.noreply.github.com>
@potiuk
Copy link
Member

potiuk commented Dec 29, 2025

Nice one! Thanks @Dev-iL !

Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
@Dev-iL @Subham-KRLX
Fix flaky tests related to github api rate limits (apache#59879)
4053a50 
- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
@github-actions @Dev-iL @ephraimbuddy
[v3-1-test] Fix flaky tests related to github api rate limits (#59879) (
f1d0390 
#59884)

- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
(cherry picked from commit dae3441)

Co-authored-by: Dev-iL <6509619+Dev-iL@users.noreply.github.com>
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
@Dev-iL @stegololz
Fix flaky tests related to github api rate limits (apache#59879)
b4e6d4d 
- Don't try to access the json of a non-200 response.
- Replace API calls with mocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@Lee-W Lee-W Lee-W approved these changes

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@jscheffl jscheffl jscheffl approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

No one assigned

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Dev-iL @potiuk @uranusjr @Lee-W @amoghrajesh @jscheffl