-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Treat non-sensitive-only as true and always mask sensitive values in public api's #59880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Let's see if CI agrees ! |
Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…public api's (apache#59880) * Treat non-sensitive-only as true and always mask sensitive values in public APIs. * Add newsfragment and update docs and client references for config masking * newline error fixed - config.yml * Update clients/python/README.md Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com> * CI image check resolved * newline error in config.py fixed --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Bas Harenslak <BasPH@users.noreply.github.com>
Summary
This PR updates the behavior of the public config API to ensure sensitive configuration values are never exposed.
Changes
expose_config=Truenon-sensitive-onlyasTrue59880.bugfix.rst)Tests
expose_config=Trueexpose_config=Falseexpose_config=non-sensitive-onlyCloses: #59860
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.