Skip to content

[AIRFLOW-3804] Extend MySQL to GCS operator tests#5993

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:extend-mysql-to-gcs-tests
Sep 5, 2019
Merged

[AIRFLOW-3804] Extend MySQL to GCS operator tests#5993
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:extend-mysql-to-gcs-tests

Conversation

@turbaszek
Copy link
Member

@turbaszek turbaszek commented Sep 3, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This commit adds additional test related to problem mentioned in initial issue https://issues.apache.org/jira/browse/AIRFLOW-3804
    I was not able to reproduce the mentioned behaviour but I think it's go to have these tests.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

This commit adds additional test related to problem mentioned in initial
issue https://issues.apache.org/jira/browse/AIRFLOW-3804\#
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants