Skip to content

Fix pre commit noise and failing master#6031

Merged
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:fix-pre-commit-noise-and-failing-master
Sep 6, 2019
Merged

Fix pre commit noise and failing master#6031
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:fix-pre-commit-noise-and-failing-master

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Sep 6, 2019

This PR has to commits (will rebase rather than squash):

Removes the noise for pre-commit tests:

  • [AIRFLOW-5411] Remove the noise produced while running failed pre-com… …

Fixes failing master because of not-rebased but merged change (it passed Travis CI before):

  • fixup! [AIRFLOW-4964] Add BigQuery Data Transfer Hook and Operator (#…

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested review from ashb and mik-laj September 6, 2019 12:00
@potiuk
Copy link
Member Author

potiuk commented Sep 6, 2019

@mik-laj -> should we merge that before Travis is complete? With the nature of the changes and fact that master is broken we should merge it asap. I think the noise should be gone now as well.

@potiuk potiuk merged commit a39ace9 into apache:master Sep 6, 2019
@potiuk potiuk deleted the fix-pre-commit-noise-and-failing-master branch September 19, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants