Skip to content

[AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python#6065

Merged
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:kms-hook-improvement
Sep 10, 2019
Merged

[AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python#6065
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:kms-hook-improvement

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Sep 9, 2019

Use google-clooud-kms library in KMS Hook

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5446
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj changed the title [AIRFLOW-5446] Rewrite Google KMS Hook with Google Api Client [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python Sep 9, 2019
@potiuk
Copy link
Member

potiuk commented Sep 9, 2019

Strange - for some reason the PR has started but there is no check in the conversation here ???? Really strange...

@mik-laj mik-laj closed this Sep 9, 2019
@mik-laj mik-laj reopened this Sep 9, 2019
@mik-laj
Copy link
Member

mik-laj commented Sep 9, 2019

Travis likes to make surprises.

@codecov-io
Copy link

Codecov Report

Merging #6065 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6065      +/-   ##
==========================================
- Coverage   80.03%   80.02%   -0.02%     
==========================================
  Files         594      594              
  Lines       34748    34763      +15     
==========================================
+ Hits        27812    27820       +8     
- Misses       6936     6943       +7
Impacted Files Coverage Δ
airflow/gcp/hooks/kms.py 100% <100%> (ø) ⬆️
airflow/contrib/operators/bigquery_operator.py 92.94% <0%> (-0.78%) ⬇️
airflow/contrib/hooks/bigquery_hook.py 70.33% <0%> (-0.41%) ⬇️
airflow/gcp/example_dags/example_bigquery.py 100% <0%> (ø) ⬆️
airflow/contrib/operators/bigquery_to_gcs.py 93.75% <0%> (+0.2%) ⬆️
airflow/contrib/operators/bigquery_to_bigquery.py 93.54% <0%> (+0.21%) ⬆️
...ontrib/operators/bigquery_table_delete_operator.py 92.3% <0%> (+0.3%) ⬆️
airflow/contrib/operators/bigquery_get_data.py 84.21% <0%> (+0.42%) ⬆️
...ow/contrib/operators/bigquery_to_mysql_operator.py 74% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd6022...3bb9ec6. Read the comment docs.

@feluelle feluelle added the provider:google Google (including GCP) related issues label Sep 9, 2019
@mik-laj mik-laj merged commit 75484bc into apache:master Sep 10, 2019
@TobKed TobKed deleted the kms-hook-improvement branch September 19, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants