Skip to content

Update postgres_hook.py#6080

Closed
KarunakarGumudala wants to merge 1 commit intoapache:masterfrom
KarunakarGumudala:patch-1
Closed

Update postgres_hook.py#6080
KarunakarGumudala wants to merge 1 commit intoapache:masterfrom
KarunakarGumudala:patch-1

Conversation

@KarunakarGumudala
Copy link

copy_expert works for flat files but not compressed,
copy_expert_gzip can copy the gzipped files to postgres table

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

copy_expert works for flat files but not compressed,
copy_expert_gzip can copy the gzipped files to postgres table
@feluelle
Copy link
Member

feluelle commented Sep 17, 2019

Welcome @KarunakarGumudala !

I like your feature 👍 but I would like to point you to a few steps that you need to change/setup first.

  • Please associate a ticket to this change as described in the PR template.
  • Also please read the Contributing guide to setup your development environment so that you can test your changes accordingly.

Thank you :)

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 20, 2019
@stale stale bot closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments