Skip to content

[AIRFLOW-5468] Fix PubSub system test class name#6085

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:fix-pubsub-system
Sep 12, 2019
Merged

[AIRFLOW-5468] Fix PubSub system test class name#6085
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:fix-pubsub-system

Conversation

@turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 12, 2019
@mik-laj mik-laj merged commit 379f440 into apache:master Sep 12, 2019
@mik-laj mik-laj deleted the fix-pubsub-system branch September 12, 2019 15:25
@codecov-io
Copy link

Codecov Report

Merging #6085 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6085      +/-   ##
==========================================
- Coverage   80.09%   80.08%   -0.01%     
==========================================
  Files         606      606              
  Lines       34893    34893              
==========================================
- Hits        27946    27945       -1     
- Misses       6947     6948       +1
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 58.8% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87f3df...7405110. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants