Skip to content

[AIRFLOW-XXX] Display GCP integration in table#6086

Merged
mik-laj merged 3 commits into
apache:masterfrom
PolideaInternal:integration-rst
Sep 15, 2019
Merged

[AIRFLOW-XXX] Display GCP integration in table#6086
mik-laj merged 3 commits into
apache:masterfrom
PolideaInternal:integration-rst

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Sep 12, 2019

Preview: http://faint-kick.surge.sh/integration.html
In addition, I ordered the names of the guide files. Now the file names of the tutorials match the names of the python files.
In the case of gcs_to_gcs, I ordered the headers.

This issue is one of a series about restructuring integration.rst
https://issues.apache.org/jira/browse/AIRFLOW-5431


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 12, 2019
@mik-laj mik-laj requested a review from potiuk September 12, 2019 17:55
Copy link
Copy Markdown
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/howto/operator/gcp/bigquery.rst → docs/howto/operator/gcp/bigquery_dts.rst

Why this rename?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 12, 2019

Codecov Report

Merging #6086 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6086      +/-   ##
==========================================
+ Coverage    80.1%   80.12%   +0.01%     
==========================================
  Files         606      606              
  Lines       34893    34944      +51     
==========================================
+ Hits        27951    27998      +47     
- Misses       6942     6946       +4
Impacted Files Coverage Δ
airflow/gcp/hooks/kubernetes_engine.py 96.66% <0%> (-1.89%) ⬇️
airflow/utils/dag_processing.py 58.8% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4459592...7f85f09. Read the comment docs.

@mik-laj
Copy link
Copy Markdown
Member Author

mik-laj commented Sep 12, 2019

@kaxil This file contains a guide that describes the BigQuery Data Transfer Service. Unfortunately, we don't have a guide for the BigQuery yet. I am trying to synchronize file names with guides, hooks and operators.
Screenshot 2019-09-12 at 20 50 14

   * - `BigQuery <https://cloud.google.com/bigquery/>`__
     -
     - :mod:`airflow.gcp.hooks.bigquery`
     - :mod:`airflow.gcp.operators.bigquery`
     - :mod:`airflow.gcp.sensors.bigquery`

   * - `BigQuery Data Transfer Service <https://cloud.google.com/bigquery/transfer/>`__
     - :doc:`How to use <howto/operator/gcp/bigquery_dts>`
     - :mod:`airflow.gcp.hooks.bigquery_dts`
     - :mod:`airflow.gcp.operators.bigquery_dts`
     - :mod:`airflow.gcp.sensors.bigquery_dts`

@mik-laj mik-laj force-pushed the integration-rst branch 2 times, most recently from 3ec1baf to 7f85f09 Compare September 13, 2019 19:20
@mik-laj mik-laj requested a review from feluelle September 14, 2019 12:25
Copy link
Copy Markdown
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/integration.rst Outdated
Comment thread docs/integration.rst Outdated
@mik-laj mik-laj merged commit fe46993 into apache:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants