[AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook#6099
Merged
mik-laj merged 2 commits intoapache:masterfrom Sep 14, 2019
Merged
Conversation
0a43e26 to
dddd9a0
Compare
dddd9a0 to
3d0815c
Compare
mik-laj
requested changes
Sep 13, 2019
| self._client = None | ||
| self.location = location | ||
|
|
||
| def get_client(self) -> container_v1.ClusterManagerClient: |
Member
There was a problem hiding this comment.
Can you add backward compatibility and deprecation warning?
Contributor
Author
There was a problem hiding this comment.
Sure. I've added it. Please check is it correct.
Codecov Report
@@ Coverage Diff @@
## master #6099 +/- ##
==========================================
- Coverage 80.1% 80.08% -0.03%
==========================================
Files 606 606
Lines 34893 34897 +4
==========================================
- Hits 27951 27947 -4
- Misses 6942 6950 +8
Continue to review full report at Codecov.
|
7eeae2c to
c77fee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation