Skip to content

[AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook#6099

Merged
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:normalize-get-conn-kubernetes-hook
Sep 14, 2019
Merged

[AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook#6099
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:normalize-get-conn-kubernetes-hook

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Sep 13, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5479
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@TobKed TobKed force-pushed the normalize-get-conn-kubernetes-hook branch 2 times, most recently from 0a43e26 to dddd9a0 Compare September 13, 2019 17:04
@mik-laj mik-laj force-pushed the normalize-get-conn-kubernetes-hook branch from dddd9a0 to 3d0815c Compare September 13, 2019 19:18
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 13, 2019
self._client = None
self.location = location

def get_client(self) -> container_v1.ClusterManagerClient:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add backward compatibility and deprecation warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I've added it. Please check is it correct.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #6099 into master will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6099      +/-   ##
==========================================
- Coverage    80.1%   80.08%   -0.03%     
==========================================
  Files         606      606              
  Lines       34893    34897       +4     
==========================================
- Hits        27951    27947       -4     
- Misses       6942     6950       +8
Impacted Files Coverage Δ
airflow/gcp/hooks/kubernetes_engine.py 95.89% <77.77%> (-2.67%) ⬇️
airflow/models/taskinstance.py 93.22% <0%> (-0.51%) ⬇️
airflow/jobs/scheduler_job.py 74.28% <0%> (-0.31%) ⬇️
airflow/utils/dag_processing.py 58.8% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0033751...c77fee6. Read the comment docs.

@TobKed TobKed force-pushed the normalize-get-conn-kubernetes-hook branch from 7eeae2c to c77fee6 Compare September 14, 2019 06:21
@mik-laj mik-laj merged commit 1adeeae into apache:master Sep 14, 2019
@mik-laj mik-laj deleted the normalize-get-conn-kubernetes-hook branch September 14, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments