Correcting misnamed argument for airflow webserver and exposing the ability to run multithreaded#610
Closed
Correcting misnamed argument for airflow webserver and exposing the ability to run multithreaded#610
Conversation
airflow/bin/cli.py
Outdated
Member
There was a problem hiding this comment.
120 threads? oh -t is for timeout
Contributor
Author
There was a problem hiding this comment.
Yep. Default timeout is 30s. No short option for threads.
…bility to run multithreaded
artwr
force-pushed
the
add_flexibility_to_webserver_with_gunicorn
branch
from
d2e9d32 to
42c5d59
Compare
Contributor
Author
|
Already provided in #618. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mistercrunch
This might enable more flexibility in how people run the webserver.
What was named threads before was actually processes, but gunicorn now has the ability to run each of theose processes multithreaded. I kept the defaults as the same as we currently have (I changed the config to reflect to correct names but the default call is the same)
Hopefully this will enable people to be more flexible in how they deploy the webserver. Still needs some testing, but putting it there for feedback.