Fix airflow-ctl-tests files not triggering pre-commit integration tests #61023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check-airflowctl-command-coverage pre-commit hook was not being triggered when files in the airflow-ctl-tests/ directory were modified. This meant that changes to integration tests could be committed without verifying that all airflowctl CLI commands had test coverage. Root cause: The hook was only defined in airflow-ctl/.pre-commit-config.yaml with file patterns attempting to match ../airflow-ctl-tests/ paths. However, prek subproject configs cannot reference files in sibling directories using relative paths - they can only match files within their own directory tree.
dheerajturaga
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:dev-tools
backport-to-v3-1-test
bugraoz93
reviewed
Jan 25, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Adding it to airflow-ctl-tests/...yaml makes a lot of sense! Thanks @dheerajturaga!
I still believe No reason to be in root hooks. So how about reverting the change on root and airflow-ctl/...yaml changes that and keeping the addition to airflow-ctl-tests/...yaml? What do you think?
bugraoz93
approved these changes
Jan 25, 2026
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 2a0497b v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
…ts (apache#61023) * Fix airflow-ctl-tests files not triggering pre-commit integration tests The check-airflowctl-command-coverage pre-commit hook was not being triggered when files in the airflow-ctl-tests/ directory were modified. This meant that changes to integration tests could be committed without verifying that all airflowctl CLI commands had test coverage. Root cause: The hook was only defined in airflow-ctl/.pre-commit-config.yaml with file patterns attempting to match ../airflow-ctl-tests/ paths. However, prek subproject configs cannot reference files in sibling directories using relative paths - they can only match files within their own directory tree. * Bugra's suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check-airflowctl-command-coverage pre-commit hook was not being
triggered when files in the airflow-ctl-tests/ directory were modified.
This meant that changes to integration tests could be committed without
verifying that all airflowctl CLI commands had test coverage.
Root cause:
The hook was only defined in airflow-ctl/.pre-commit-config.yaml with
file patterns attempting to match ../airflow-ctl-tests/ paths. However,
prek subproject configs cannot reference files in sibling directories
using relative paths - they can only match files within their own
directory tree.