Fix TriggerDagRunOperator extra link visibility during task execution #61045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Triggered DAG' button was only appearing after the TriggerDagRunOperator task completed, even though the child DAG run was created while the task was still RUNNING. Root cause: XCom pushed during task execution wasn't immediately visible to API queries because it used a separate database session/transaction. Solution: Pass the session parameter from the executing method to xcom_push() to ensure the XCom is persisted in the same transaction and immediately queryable by the extra links API while the task is still RUNNING. Changes: - Import provide_session decorator and NEW_SESSION constant - Add @provide_session decorator to _trigger_dag_af_2 method - Pass session parameter to ti.xcom_push() call This minimal change ensures the 'Triggered DAG' button appears immediately when the child DAG run is created, providing better UX without requiring users to wait for task completion.
Arunodoy18
force-pushed
the
fix/trigger-dag-button-visible-while-running
branch
from
b02a35e to
a364eef
Compare
Contributor
|
Another contributor was assigned to this task by me only today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In Airflow 3.1.6, the UI displays the “Triggered DAG” button for TriggerDagRunOperator only after the task reaches a terminal state. However, the triggered DAG run is created earlier, while the task is still running.
This PR updates the UI to surface the “Triggered DAG” link as soon as the child DAG run exists, without waiting for task completion or requiring a page refresh.
Problem:
TriggerDagRunOperator creates a child DAG run while the task is still in the RUNNING state
The Airflow UI delays rendering the “Triggered DAG” button until the task finishes
This creates a mismatch between backend state and UI visibility and makes navigation to the triggered DAG unnecessarily delayed
Solution:
The UI logic is adjusted to determine the availability of the “Triggered DAG” button based on the existence of the child DAG run rather than the parent task’s terminal state.
This change:
Does not modify TriggerDagRunOperator execution behavior
Does not affect scheduling or DAG run creation
Improves UI consistency and user experience
Backward Compatibility
No breaking changes
Existing DAGs continue to work as before, with improved UI feedback
Tests
Updated / added coverage to ensure the triggered DAG link is visible while the operator task is still running
Related issue
Closes #60867