Skip to content

Revert "[AIRFLOW-5488]Remove unused variables from tmp_configuration_…#6120

Merged
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:fix-failing-master-after-removing-params
Sep 16, 2019
Merged

Revert "[AIRFLOW-5488]Remove unused variables from tmp_configuration_…#6120
mik-laj merged 1 commit intoapache:masterfrom
PolideaInternal:fix-failing-master-after-removing-params

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Sep 16, 2019

…copy method (#6114)"

This reverts commit 31b7bc9.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested review from jghoman and mik-laj September 16, 2019 09:49
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5bbd00e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6120   +/-   ##
=========================================
  Coverage          ?   79.88%           
=========================================
  Files             ?      607           
  Lines             ?    34905           
  Branches          ?        0           
=========================================
  Hits              ?    27883           
  Misses            ?     7022           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/utils/configuration.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbd00e...d8414ce. Read the comment docs.

@mik-laj mik-laj merged commit 8ea2a07 into apache:master Sep 16, 2019
@potiuk potiuk deleted the fix-failing-master-after-removing-params branch September 19, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants