Skip to content

[AIRFLOW-5498] Move GCP Discovery hook to core#6121

Merged
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:gcp-discovery-to-core2
Sep 17, 2019
Merged

[AIRFLOW-5498] Move GCP Discovery hook to core#6121
mik-laj merged 2 commits intoapache:masterfrom
PolideaInternal:gcp-discovery-to-core2

Conversation

@turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@turbaszek
Copy link
Member Author

This PR will require note after #6119

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Sep 16, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5498] Move Discovery hook to core [AIRFLOW-5498] Move GCP Discovery hook to core Sep 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #6121 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6121      +/-   ##
==========================================
+ Coverage   80.12%   80.13%   +<.01%     
==========================================
  Files         607      609       +2     
  Lines       34905    34922      +17     
==========================================
+ Hits        27967    27984      +17     
  Misses       6938     6938
Impacted Files Coverage Δ
airflow/contrib/hooks/google_discovery_api_hook.py 100% <100%> (ø) ⬆️
...low/contrib/operators/google_api_to_s3_transfer.py 100% <100%> (ø) ⬆️
airflow/operators/google_api_to_s3_transfer.py 100% <100%> (ø)
airflow/gcp/hooks/discovery_api.py 100% <100%> (ø)
airflow/jobs/scheduler_job.py 74.28% <0%> (-0.31%) ⬇️
airflow/utils/dag_processing.py 58.98% <0%> (+0.18%) ⬆️
airflow/api/common/experimental/delete_dag.py 94.28% <0%> (+5.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea2a07...26bd0ea. Read the comment docs.

@mik-laj mik-laj merged commit 686fac0 into apache:master Sep 17, 2019
@turbaszek turbaszek deleted the gcp-discovery-to-core2 branch September 19, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments